Existing consistency test patterns from Phase 4 and 5 to follow exactly

The test file should contain these test functions (following the split-test pattern from D-04-05-01):

1. TestGoGeneratorsProduceIdenticalTimestampFormat -- Compare golden files:

   • Read httpgen golden file: testdata/golden/timestamp_format_timestamp_format.pb.go
   • Read clientgen golden file: ../clientgen/testdata/golden/timestamp_format_timestamp_format.pb.go
   • Normalize generator comments using normalizeGeneratorComment (from encoding_consistency_test.go)
   • Assert byte-level equality after normalization

2. TestTimestampFormatTypeScriptTypes -- Verify TS type mapping:

   • Read tsclientgen golden file for timestamp_format
   • Verify UNIX_SECONDS and UNIX_MILLIS fields use number type
   • Verify RFC3339 and DATE fields use string type
   • Verify default (unannotated) Timestamp fields use string type

3. TestTimestampFormatOpenAPISchemas -- Verify OpenAPI schemas:

   • Read openapiv3 golden file for timestamp_format
   • Verify UNIX_SECONDS field has type: integer, format: unix-timestamp
   • Verify UNIX_MILLIS field has type: integer, format: unix-timestamp-ms
   • Verify DATE field has type: string, format: date
   • Verify RFC3339/default fields have type: string, format: date-time

4. TestTimestampFormatCrossGeneratorAgreement -- Cross-check all generators agree:

   • For each timestamp format variant, verify:
     • Go type in generated code matches TS type expectation
     • OpenAPI schema type matches what Go will actually produce
   • Table-driven test with one row per format:

     testCases := []struct {
         format         string
         goProducesType string  // "integer" or "string"
         tsType         string  // "number" or "string"
         openapiType    string  // "integer" or "string"
         openapiFormat  string  // "unix-timestamp", "date-time", etc.
     }{
         {"UNIX_SECONDS",  "integer", "number", "integer", "unix-timestamp"},
         {"UNIX_MILLIS",   "integer", "number", "integer", "unix-timestamp-ms"},
         {"DATE",          "string",  "string", "string",  "date"},
         {"RFC3339",       "string",  "string", "string",  "date-time"},
         {"default",       "string",  "string", "string",  "date-time"},
     }

   • Parse golden files to extract actual types and formats per field
   • Compare against expected values

Implementation approach: Read golden files from disk (same as existing consistency tests). Parse Go golden for MarshalJSON patterns, TS golden for type declarations, OpenAPI golden for schema definitions. Use string matching and regex patterns.

go test -v -run TestTimestampFormat ./internal/httpgen/...
make lint-fix

1. TestGoGeneratorsProduceIdenticalBytesEncoding -- Compare golden files:

   • Read httpgen golden file: testdata/golden/bytes_encoding_bytes_encoding.pb.go
   • Read clientgen golden file: ../clientgen/testdata/golden/bytes_encoding_bytes_encoding.pb.go
   • Normalize generator comments
   • Assert byte-level equality after normalization

2. TestBytesEncodingTypeScriptTypes -- Verify TS types:

   • Read tsclientgen golden file for bytes_encoding
   • Verify ALL bytes encoding variants produce string type in TypeScript
   • No encoding variant should produce any type other than string

3. TestBytesEncodingOpenAPISchemas -- Verify OpenAPI schemas:

   • Read openapiv3 golden file for bytes_encoding
   • Verify HEX field has format: hex and pattern: ^[0-9a-fA-F]*$
   • Verify BASE64_RAW has format: byte with description about no padding
   • Verify BASE64URL has format: base64url
   • Verify BASE64URL_RAW has format: base64url with description about no padding
   • Verify default/BASE64 has format: byte

4. TestBytesEncodingCrossGeneratorAgreement -- Cross-check all generators agree:

   • Table-driven test with one row per encoding:

     testCases := []struct {
         encoding      string
         tsType        string  // always "string"
         openapiType   string  // always "string"
         openapiFormat string  // "byte", "hex", "base64url"
     }{
         {"HEX",           "string", "string", "hex"},
         {"BASE64_RAW",    "string", "string", "byte"},
         {"BASE64URL",     "string", "string", "base64url"},
         {"BASE64URL_RAW", "string", "string", "base64url"},
         {"BASE64",        "string", "string", "byte"},
         {"default",       "string", "string", "byte"},
     }

   • Parse golden files to extract actual types and formats
   • Compare against expected values

Implementation approach: Same as timestamp_format -- read golden files, parse patterns, compare.

go test -v -run TestBytesEncoding ./internal/httpgen/...
make lint-fix

1. All existing tests still pass (zero regression)
2. All new consistency tests pass
3. All golden files are up to date
4. Lint is clean

# Full test suite
go test ./...
 
# Specific generator tests
go test -v ./internal/httpgen/... ./internal/clientgen/... ./internal/tsclientgen/... ./internal/openapiv3/...
 
# Golden file tests
go test -v -run TestExhaustiveGoldenFiles ./internal/...
 
# All consistency tests (Phase 4, 5, and 6)
go test -v -run "Consistency|Identical" ./internal/httpgen/...
 
# Lint check
make lint-fix

Verify that:

• timestamp_format and bytes_encoding golden files exist for all 4 generators
• Generated code matches expected golden output
• Cross-generator consistency verified for all data encoding combinations
• No regressions in any Phase 4 or Phase 5 tests

If any test fails, debug and fix. The consistency tests are the final gate ensuring Phase 6 success criteria 6 is met.

go test ./...
make lint-fix

All tests pass, lint clean, no regressions.

• All 4 generators produce consistent output for timestamp_format fields
• All 4 generators produce consistent output for bytes_encoding fields
• go-http and go-client produce byte-identical encoding code for both features
• TypeScript types match Go serialization for all format/encoding combinations
• OpenAPI schemas match Go serialization for all format/encoding combinations
• All Phase 4 and Phase 5 consistency tests still pass (zero regression)
• Full test suite passes
• Lint clean